Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign-out route on backend does not invalidate JWT token #28

Open
rbetancor opened this issue Aug 28, 2019 · 1 comment
Open

sign-out route on backend does not invalidate JWT token #28

rbetancor opened this issue Aug 28, 2019 · 1 comment

Comments

@rbetancor
Copy link

I buyed the flask-starter bundle and if called the /auth/logout route from the frontend code, that makes a call to the backend route /api/auth/sign-out, we get a 401 from the backend, morever taking a look at the backend code, it doesn't invalidate the JWT token created on the loging procedure, in fact the backend code does NOTHING, just return a "200 Logged out" without doing anything more.

Another thing is that the /pages/users front-end code, to list and edit users, doesn't work either, the code is there, but unable to call it to show the users table.

Seems that the bundle is mostly incomplete or broken, no docs and just only the register/login backend source code works, the rest seems like the ngx-admin standar from the github repo.

@robledosm
Copy link

Checking a little bit deeper, the SignOut method of the in the AuthenticationService throws a "NotImplementedException" As @rbetancor said, the controller just returns an Ok response without calling the service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants