Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make promoter info (username and email, at least) available in expressions #3081

Open
Sebast1aan opened this issue Dec 6, 2024 · 1 comment

Comments

@Sebast1aan
Copy link
Contributor

Checklist

  • [ X] I've searched the issue queue to verify this is not a duplicate feature request.
  • [ X] I've pasted the output of kargo version, if applicable.
  • [ X] I've pasted logs, if applicable.

Proposed Feature

When currently using the git-commit promotion step, the commits are done with the default user kargo (if no explicit author.name is set). If a promotion is done manually, it would be useful that this becomes kargo-$logged-in-user (such as kargo-admin, in case you log in with the admin account). In the promotion history you can already see who initiated the promotion, but in the git commit log itself there is no trace of it.

Motivation

This would enable to easily see who initiated a git commit from within kargo.

@krancour
Copy link
Member

krancour commented Dec 9, 2024

I think the most sensible thing here might be to make promoter information available within expressions, so you can dynamically populate the existing author info fields.

@krancour krancour changed the title git-commit: include promotor username into git commit author make promoter info (username and email, at least) available in expressions Dec 9, 2024
@krancour krancour self-assigned this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants