diff --git a/account_refund_no_business_field/README.rst b/account_refund_no_business_field/README.rst new file mode 100644 index 00000000..999082fe --- /dev/null +++ b/account_refund_no_business_field/README.rst @@ -0,0 +1,79 @@ +================================ +Account Refund No Business Field +================================ + +.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fak--odoo--incubator-lightgray.png?logo=github + :target: https://github.com/OCA/ak-odoo-incubator/tree/16.0/account_refund_no_business_field + :alt: OCA/ak-odoo-incubator +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/ak-odoo-incubator-16-0/ak-odoo-incubator-16-0-account_refund_no_business_field + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png + :target: https://runboat.odoo-community.org/webui/builds.html?repo=OCA/ak-odoo-incubator&target_branch=16.0 + :alt: Try me on Runboat + +|badge1| |badge2| |badge3| |badge4| |badge5| + +When creating a refund with a different mode than 'modify' (Full refund and new draft invoice), avoid copying business fields (which are the link between invoice lines and sale or purchase lines in native Odoo). +These business fields impact the quantity invoiced on sale and purchase order lines, decreasing it. + +The main case this modules aims to fix is the following : +A sale order is fully invoiced. A refund is made on this invoice, the quantity invoiced is decreased and the invoicing state of the sale order goes back to "to invoice". +Then, a second invoice may be generated. +This is especially an issue when using sale_automatic_workflow with automatic invoice creation. + +**Table of contents** + +.. contents:: + :local: + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us smashing it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +~~~~~~~ + +* Akretion + +Contributors +~~~~~~~~~~~~ + +* Florian da Costa + +Maintainers +~~~~~~~~~~~ + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +This module is part of the `OCA/ak-odoo-incubator `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/account_refund_no_business_field/__init__.py b/account_refund_no_business_field/__init__.py new file mode 100644 index 00000000..aee8895e --- /dev/null +++ b/account_refund_no_business_field/__init__.py @@ -0,0 +1,2 @@ +from . import models +from . import wizards diff --git a/account_refund_no_business_field/__manifest__.py b/account_refund_no_business_field/__manifest__.py new file mode 100644 index 00000000..d46c01b4 --- /dev/null +++ b/account_refund_no_business_field/__manifest__.py @@ -0,0 +1,16 @@ +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). + +{ + "name": "Account Refund No Business Field", + "version": "16.0.1.0.0", + "category": "Sale", + "author": "Akretion,Odoo Community Association (OCA)", + "website": "https://github.com/akretion/ak-odoo-incubator", + "license": "AGPL-3", + "depends": [ + "account", + # this is a functional dependency + "sale", + ], + "installable": True, +} diff --git a/account_refund_no_business_field/models/__init__.py b/account_refund_no_business_field/models/__init__.py new file mode 100644 index 00000000..8795b3be --- /dev/null +++ b/account_refund_no_business_field/models/__init__.py @@ -0,0 +1 @@ +from . import account_move_line diff --git a/account_refund_no_business_field/models/account_move_line.py b/account_refund_no_business_field/models/account_move_line.py new file mode 100644 index 00000000..fa598b71 --- /dev/null +++ b/account_refund_no_business_field/models/account_move_line.py @@ -0,0 +1,13 @@ +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). + + +from odoo import models + + +class AccountMoveLine(models.Model): + _inherit = "account.move.line" + + def _copy_data_extend_business_fields(self, values): + if self.env.context.get("refund_mode", "") in ("refund", "cancel"): + return + return super()._copy_data_extend_business_fields(values) diff --git a/account_refund_no_business_field/readme/CONTRIBUTORS.rst b/account_refund_no_business_field/readme/CONTRIBUTORS.rst new file mode 100644 index 00000000..0bddb053 --- /dev/null +++ b/account_refund_no_business_field/readme/CONTRIBUTORS.rst @@ -0,0 +1 @@ +* Florian da Costa diff --git a/account_refund_no_business_field/readme/DESCRIPTION.rst b/account_refund_no_business_field/readme/DESCRIPTION.rst new file mode 100644 index 00000000..fb2ca760 --- /dev/null +++ b/account_refund_no_business_field/readme/DESCRIPTION.rst @@ -0,0 +1,7 @@ +When creating a refund with a different mode than 'modify' (Full refund and new draft invoice), avoid copying business fields (which are the link between invoice lines and sale or purchase lines in native Odoo). +These business fields impact the quantity invoiced on sale and purchase order lines, decreasing it. + +The main case this modules aims to fix is the following : +A sale order is fully invoiced. A refund is made on this invoice, the quantity invoiced is decreased and the invoicing state of the sale order goes back to "to invoice". +Then, a second invoice may be generated. +This is especially an issue when using sale_automatic_workflow with automatic invoice creation. diff --git a/account_refund_no_business_field/readme/ROADMAP.rst b/account_refund_no_business_field/readme/ROADMAP.rst new file mode 100644 index 00000000..6760e9d7 --- /dev/null +++ b/account_refund_no_business_field/readme/ROADMAP.rst @@ -0,0 +1 @@ +With this module, if you create a refund on a sale order invoice, it won't be link to the sale order (it won't be visible from the sale order in the UI) diff --git a/account_refund_no_business_field/static/description/index.html b/account_refund_no_business_field/static/description/index.html new file mode 100644 index 00000000..9d5f6866 --- /dev/null +++ b/account_refund_no_business_field/static/description/index.html @@ -0,0 +1,424 @@ + + + + + + +Account Refund No Business Field + + + +
+

Account Refund No Business Field

+ + +

Beta License: AGPL-3 OCA/ak-odoo-incubator Translate me on Weblate Try me on Runboat

+

When creating a refund with a different mode than ‘modify’ (Full refund and new draft invoice), avoid copying business fields (which are the link between invoice lines and sale or purchase lines in native Odoo). +These business fields impact the quantity invoiced on sale and purchase order lines, decreasing it.

+

The main case this modules aims to fix is the following : +A sale order is fully invoiced. A refund is made on this invoice, the quantity invoiced is decreased and the invoicing state of the sale order goes back to “to invoice”. +Then, a second invoice may be generated. +This is especially an issue when using sale_automatic_workflow with automatic invoice creation.

+

Table of contents

+ +
+

Bug Tracker

+

Bugs are tracked on GitHub Issues. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us smashing it by providing a detailed and welcomed +feedback.

+

Do not contact contributors directly about support or help with technical issues.

+
+
+

Credits

+
+

Authors

+
    +
  • Akretion
    • +
+
+
+

Contributors

+ +
+
+

Maintainers

+

This module is maintained by the OCA.

+Odoo Community Association +

OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use.

+

This module is part of the OCA/ak-odoo-incubator project on GitHub.

+

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

+
+
+
+ + diff --git a/account_refund_no_business_field/tests/__init__.py b/account_refund_no_business_field/tests/__init__.py new file mode 100644 index 00000000..88b89bba --- /dev/null +++ b/account_refund_no_business_field/tests/__init__.py @@ -0,0 +1 @@ +from . import test_refund_no_business_field diff --git a/account_refund_no_business_field/tests/test_refund_no_business_field.py b/account_refund_no_business_field/tests/test_refund_no_business_field.py new file mode 100644 index 00000000..2c9f894f --- /dev/null +++ b/account_refund_no_business_field/tests/test_refund_no_business_field.py @@ -0,0 +1,40 @@ +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). +import odoo.tests.common as common + + +class TestSale(common.TransactionCase): + def test_refund_no_business_field(self): + # more kind of functional test because this module aims to fix this specific + # case. + sale = self.env.ref("sale.sale_order_7") + self.assertEqual(sale.invoice_status, "to invoice") + wizard = ( + self.env["sale.advance.payment.inv"] + .with_context( + active_model="sale.order", active_id=sale.id, active_ids=sale.ids + ) + .create( + { + "advance_payment_method": "delivered", + } + ) + ) + wizard.create_invoices() + self.assertEqual(sale.invoice_status, "no") + invoice = sale.invoice_ids + invoice.action_post() + refund_wizard = ( + self.env["account.move.reversal"] + .with_context(active_model="account.move", active_ids=invoice.ids) + .create( + { + "journal_id": invoice.journal_id.id, + "reason": "no reason", + "refund_method": "refund", + } + ) + ) + refund_wizard.reverse_moves() + # Check sale invoice state stay the same which is the main goal of the + # module + self.assertEqual(sale.invoice_status, "no") diff --git a/account_refund_no_business_field/wizards/__init__.py b/account_refund_no_business_field/wizards/__init__.py new file mode 100644 index 00000000..715d1bd6 --- /dev/null +++ b/account_refund_no_business_field/wizards/__init__.py @@ -0,0 +1 @@ +from . import account_move_reversal diff --git a/account_refund_no_business_field/wizards/account_move_reversal.py b/account_refund_no_business_field/wizards/account_move_reversal.py new file mode 100644 index 00000000..19bdad98 --- /dev/null +++ b/account_refund_no_business_field/wizards/account_move_reversal.py @@ -0,0 +1,13 @@ +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). + + +from odoo import models + + +class AccountMoveReversal(models.TransientModel): + _inherit = "account.move.reversal" + + def reverse_moves(self): + return super( + AccountMoveReversal, self.with_context(refund_mode=self.refund_method) + ).reverse_moves() diff --git a/setup/account_refund_no_business_field/odoo/addons/account_refund_no_business_field b/setup/account_refund_no_business_field/odoo/addons/account_refund_no_business_field new file mode 120000 index 00000000..a045bc18 --- /dev/null +++ b/setup/account_refund_no_business_field/odoo/addons/account_refund_no_business_field @@ -0,0 +1 @@ +../../../../account_refund_no_business_field \ No newline at end of file diff --git a/setup/account_refund_no_business_field/setup.py b/setup/account_refund_no_business_field/setup.py new file mode 100644 index 00000000..28c57bb6 --- /dev/null +++ b/setup/account_refund_no_business_field/setup.py @@ -0,0 +1,6 @@ +import setuptools + +setuptools.setup( + setup_requires=['setuptools-odoo'], + odoo_addon=True, +)