Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]Add option to add all video links in a webpage playlist to mpv playlist #22

Open
ieeyaY opened this issue Aug 9, 2024 · 3 comments

Comments

@ieeyaY
Copy link

ieeyaY commented Aug 9, 2024

As of right now, the userscript can only add the URL to the video that is playing. Could you include an option to add links from webpage , such as youtube playlist, to an MPV playlist?

@akiirui
Copy link
Owner

akiirui commented Aug 9, 2024

Because the webpage parsing is based on yt-dlp, if yt-dlp doesn't support the playlist on this page, then it will not work.

Adding a play button on such a page will mislead users.

But if you want to play YouTube playlists, it is fine. I just tested the current version of the user script, and it doesn't work at all on Youtube. It is because Youtube updated the CSP rules, which caused a line of code in the script to not work, which has now been fixed.

@akiirui
Copy link
Owner

akiirui commented Aug 9, 2024

image

@akiirui
Copy link
Owner

akiirui commented Aug 10, 2024

And you should to know, apply an userscript to all pages need a permission @match https://violentmonkey.github.io/api/matching/

If it matching all page like @match *://*/*, it is dangerous (This script will run on all web pages, bringing unnecessary risks). So I try to use minimal matching to avoid the above situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants