Merge pull request #7 in KSD/cli-appsec from feature/KSD-14282 to develop

* commit 'b98a392f5e645db3a1779b5029a8062c9e9511f1':
  Remove old method.

Author: Arul Nedumaran

src/appSecConfig.js

@@ -19,7 +19,6 @@ class AppSecConfig {
   }
 
   versions(options) {
-
     return this._configProvider.getConfigId(options.config)
     .then((configId) => {
         return new Promise((resolve) => {
@@ -51,7 +50,6 @@ class AppSecConfig {
   }
 
   version(options) {
-
     return this._configProvider.getConfigId(options.config)
     .then((configId) => {
         return new Promise((resolve) => {
@@ -72,31 +70,8 @@ class AppSecConfig {
         throw err;
       });
   }
-
-  rules(providedConfigId) {
-
-    let configId = this._getConfigId(providedConfigId);
-
-    return new Promise((resolve, reject) => {
-      let customRulesUrl = URIs.GET_CRB.format(configId);
-      logger.debug("Attempting to get all custom rules at: " + customRulesUrl);
-      let request = {
-        method: "GET",
-        path: customRulesUrl,
-        followRedirect: false
-      };
-      this._edge.auth(request).send(function (data, response) {
-        if (response && response.statusCode >= 200 && response.statusCode < 400) {
-          let parsed = JSON.parse(response.body);
-          resolve(parsed);
-        } else {
-          reject(data);
-        }
-      });
-    });
-  }
 }
 
 module.exports = {
   AppSecConfig: AppSecConfig
-};
+};

src/constants.js

@@ -12,13 +12,14 @@ var logger = function (loggerName) {
         name: loggerName
     });
 };
-
+const CRB='/appsec-resource/v1/configs/%s/custom-rules';
 var resources = {
     "GET_CONFIGS": '/appsec-configuration/v1/configs',
     "GET_VERSIONS": '/appsec-configuration/v1/configs/%s/versions',
     "GET_VERSION": '/appsec-configuration/v1/configs/%s/versions/%s',
-    "GET_CRB": '/appsec-resource/v1/configs/%s/custom-rules'
+    "GET_CRB_ALL": CRB,
+    "GET_CRB": CRB + '/%s'
 };
 
 define("URIS", resources);
-define("logger", logger);
+define("logger", logger);

src/crb.js

@@ -36,7 +36,7 @@ class CRBHandler {
     rules(providedConfigId) {
         let configId = this._configProvider.getConfigId(providedConfigId);
         return new Promise((resolve, reject) => {
-                let customRulesUrl  = util.format(URIs.GET_CRB, configId);
+                let customRulesUrl  = util.format(URIs.GET_CRB_ALL, configId);
                 logger.debug("Attempting to get all custom rules at: " + customRulesUrl);
             let request = {
                 method: "GET",