-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GoogLeNet.hs: pdf output doesn't work #14
Comments
I'm just tried to create the pdf from AlexNet, and get the same error. It seems that the error somewhere inside the package. Btw, png output doesn't work either (the same output). |
I got a stacktrace:
UPD: ah, forgot — the stacktrace is from AlexNet.hs, though, it have the same problem. |
Do you have graphviz installed? What does |
It says
Yay, well, that was an easy bug — adding that to README surely won't break the the compilation ☺ |
Btw, is there anywhere an example of recurrent network in the dnngraph? |
Man, I know, you won't care, but I wanna write it anyway. I hate you. Just for you to know: I was writing my diploma about some sort of LSTM nets application, so I choose Haskell because it is the fastest (in the development rate sense) and the most reliable language of what I know. As devel. fastest I could also choose Python, but it isn't reliable, and also the project actually should go further than just diploma, so I preferred Haskell. To my surprise I didn't find a project in Haskell that does LSTM. I was about to give up, when I found out of hackage your project — it is said to be DSL to two another libraries, which are, according to Google, have recurrent networks and tutorials for writing LSTM. «This is my chance!» — I thought. Although grepping over the code found neither of "recurr", "lstm", "rnn" (any case), but I was sure, at least, I could apply a backend tutorial for this code. I was just writing the last, practice, chapter, and for reasons beyond my control I was a bit late. So, to not lose time for nothing, I start writing how I am doing the research of the dnngraph code. For writing time I omitted a bunch of research process, and, relatively, for every second sentence I spent at least five minutes. And despite that now I filled the least volume I was needed (18 pages), and ¾ of that text is just how I'm trying to find a way to make at least plain FF network — which is half way to recurrent, which is half way to LSTM. I'm still on my way to the least network, I'm now completely out of time, and I have no idea what to do now. I see, you're a good mathematician, also I am not that experienced in Haskell as you're. But let me give you some advices. First: check whatever you does in IO! This bug with graphviz app is the obvious example. I know, peoples says that in Haskell no bugs once the program compiles, but that is only due to the great type system — and whatever IO does is out of it! So, if you're doing anything with it, like executing an external app — you have to be ready for anything to go wrong, and to print whatever gone wrong! Second, please, name variables and types correctly! Of course, variables like «a, b, c» are fine when the function is just a few lines long. But you should not name that omnipresent type Third, please, leave comments! I know, that code might be obvious to yourself, but it is often not for every one else. For example, could you say, what does the function stack? Let me do it, it is
Easy, right? The problem is that I am still not even sure it is absolutely right, and even that took me about a hour to figure it out. Just look at that code, a bunch of comments, most of which even could be compiled into documentation. And compare it with dnngraph — not just there is no comments to be compiled into documentation, there is no comments at all! |
@ajtulloch please, add to the README a note like «The project is under heavily refactoring, and is not recommended to use», or whatever alike. Because I'm sure, you won't do refactoring in any close time, if you'd do it ever, and that text would surely save someone's time. You actually made just every possible architecture error, that could be done with disregard to specific environment and language. Btw, if you would ever start refactoring, I'd recommend to start from the |
@Hi-Angel those are some pretty offensive comments! |
@alexanderkjeldaas they're for a reason, aren't they? The most intimidating in the whole thing is that the project has so many forks and stars. They're clearly peoples, who didn't even try to do anything with this, and this is bad, because they delude others into thinking that this works, and makes them spend great amounts of time in vain. |
@alexanderkjeldaas and FYI: I struggle to say what people call "offensive". It's an abstract notion over many so different sets that I gave up to get it to anything meaningful. But if these particular comments turned out to be "offensive" — well, they probably had the reason anyway. |
It's saying:
The text was updated successfully, but these errors were encountered: