Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider respecting the system accent colour on Safari's toolbar icon #1324

Closed
strafe opened this issue May 20, 2022 · 7 comments · Fixed by #2162
Closed

Consider respecting the system accent colour on Safari's toolbar icon #1324

strafe opened this issue May 20, 2022 · 7 comments · Fixed by #2162

Comments

@strafe
Copy link
Contributor

strafe commented May 20, 2022

I'm not familiar with extension development for Safari, but it would seem it's possible to provide a non-colour icon and allow the system accent colour to show that the extension is active.

@mchangrh
Copy link
Contributor

This seems like it should be theme-color or accent-color but there is also no dynamic elements to the icon iirc (see #930)

@strafe
Copy link
Contributor Author

strafe commented May 23, 2022

@mchangrh I'm not sure what those have to do with this sorry. I did find a write up that explains Safari has some sort of built-in feature that detects if an extension's icon is grayscale or not, if it is, then it will allow it to be tinted using the system's accent colour.

This wouldn't require any additional functionality as the icon is only tinted when Safari considers the extension to be "active" (so when on youtube.com).

@mchangrh
Copy link
Contributor

Ah, I thought that Apple would at least document it or have it behind a feature flag like they did with theme or accent colour (which were reported by users), but unfortunately it seems that it's not documented and up to trial and error.

Personally I find it quite odd since SponsorBlock leans quite heavily into the red theme - IIRC 1Password isn't deliberately blending in with a greyscale icon, they just also happen to feature blue as their theme, just a happy coincidence

@strafe
Copy link
Contributor Author

strafe commented May 24, 2022

1Password is using this in the screenshot I posted above. The Safari helper in 1Password 7 and below can be tinted with the system accent colour. Red example:
CleanShot 2022-05-24 at 04 03 17@2x

In fact they've just changed how thinks works in 1Password 8, and the new Safari extension borrows heavily from their Chrome extension and loses this functionality, there's already a thread of people complaining.

@strafe
Copy link
Contributor Author

strafe commented Jul 6, 2023

I can't find the update that added this but it seems to be working now(?), thanks @ajayyy
image

@strafe strafe closed this as completed Jul 6, 2023
@ajayyy
Copy link
Owner

ajayyy commented Jul 6, 2023

didn't do anything :P but looks nice

@strafe
Copy link
Contributor Author

strafe commented Nov 28, 2024

Sad news everyone, after updating to Sequoia the icon is now red again when SponsorBlock is active :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants