-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider respecting the system accent colour on Safari's toolbar icon #1324
Comments
This seems like it should be |
@mchangrh I'm not sure what those have to do with this sorry. I did find a write up that explains Safari has some sort of built-in feature that detects if an extension's icon is grayscale or not, if it is, then it will allow it to be tinted using the system's accent colour. This wouldn't require any additional functionality as the icon is only tinted when Safari considers the extension to be "active" (so when on youtube.com). |
Ah, I thought that Apple would at least document it or have it behind a feature flag like they did with theme or accent colour (which were reported by users), but unfortunately it seems that it's not documented and up to trial and error. Personally I find it quite odd since SponsorBlock leans quite heavily into the red theme - IIRC 1Password isn't deliberately blending in with a greyscale icon, they just also happen to feature blue as their theme, just a happy coincidence |
1Password is using this in the screenshot I posted above. The Safari helper in 1Password 7 and below can be tinted with the system accent colour. Red example: In fact they've just changed how thinks works in 1Password 8, and the new Safari extension borrows heavily from their Chrome extension and loses this functionality, there's already a thread of people complaining. |
I can't find the update that added this but it seems to be working now(?), thanks @ajayyy |
didn't do anything :P but looks nice |
Sad news everyone, after updating to Sequoia the icon is now red again when SponsorBlock is active :( |
I'm not familiar with extension development for Safari, but it would seem it's possible to provide a non-colour icon and allow the system accent colour to show that the extension is active.
The text was updated successfully, but these errors were encountered: