-
Notifications
You must be signed in to change notification settings - Fork 41
Allow consumers to set flags on keys #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think we can implement this without change And we only implmented some basic types, like However, this need users to write a lot of boilerplate codes, therefor, I think we can add a builtin struct with implement this trait, and which hold a flags and other informations, this can be used for users, also can be used to implement #143. |
Interesting idea. I'm unsure how we'd implement this as I'm still getting used to this codebase but I'll do some investigation today and see what I can come up with |
So, looking at the code again, I don't see how we would be able to do this without having consumers implement |
Uh oh!
There was an error while loading. Please reload this page.
Currently consumers have no way to set flags when writing to memcached. We should allow them to do so, however this would require changes in
ProtocolTrait
which will end up being a breaking change for current consumers. On the upside, if we're making a breaking change we have the opportunity to bring in async as well, which would also resolve #20 (not by using tokio specifically but by supporting async operations. Consumers can choose what async runtime they want to use)The text was updated successfully, but these errors were encountered: