Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to deal with Github API limits in ephemeral build runners. #10828

Closed
davinchia opened this issue Mar 3, 2022 · 4 comments
Closed
Assignees
Labels
area/platform issues related to the platform team/compose team/platform-move type/enhancement New feature or request

Comments

@davinchia
Copy link
Contributor

davinchia commented Mar 3, 2022

Tell us about the problem you're trying to solve

Today we are running into Github API limit errors when creating new ephemeral build runners: https://github.com/airbytehq/airbyte/runs/5406131335?check_suite_focus=true#step:3:244

This is probably because we are running more and more builds and hitting the 5k PAT limit.

Github rate limit: https://docs.github.com/en/developers/apps/building-github-apps/rate-limits-for-github-apps#user-to-server-requests

Build action we use: https://github.com/machulav/ec2-github-runner

This is probably an infrastructure issue. Dropping it here for tracking.

Describe the solution you’d like

  • confirm root cause
  • propose alternative solution

Describe the alternative you’ve considered or used

A clear and concise description of any alternative solutions or features you've considered or are using today.

Additional context

Add any other context or screenshots about the feature request here.

Are you willing to submit a PR?

Remove this with your answer :-)

@davinchia davinchia added type/enhancement New feature or request needs-triage area/platform issues related to the platform and removed needs-triage labels Mar 3, 2022
@davinchia
Copy link
Contributor Author

Opened an issue on the action repo: machulav/ec2-github-runner#94

@supertopher
Copy link
Contributor

@erica-airbyte do you know if syncs run using GitHub Actions, and therefore presumably increasing our API count.

This problem would of course be compounded with retries if we are already near/over our limit

@erica-airbyte
Copy link
Contributor

I do not know, sorry!

@davinchia
Copy link
Contributor Author

Nope. Syncs happen within Kubernetes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform team/compose team/platform-move type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants