Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong string for pt-BR locale #139

Open
lcneves opened this issue Nov 14, 2019 · 2 comments
Open

Wrong string for pt-BR locale #139

lcneves opened this issue Nov 14, 2019 · 2 comments

Comments

@lcneves
Copy link

lcneves commented Nov 14, 2019

index.js, line 102:
french: ['fr', 'tl', 'pt-br'],

Should be:
french: ['fr', 'tl', 'pt-BR'],

@ljharb
Copy link
Collaborator

ljharb commented Nov 14, 2019

cc @schleyfox to confirm that we don't need to keep both capitalizations

@schleyfox
Copy link
Contributor

I don't think we do any handling of the locales that are passed in that would make this case insensitive, so changing the capitalization could be breaking. You'd probably need both capitalizations.

likeavirgil added a commit to likeavirgil/polyglot.js that referenced this issue Jun 29, 2021
likeavirgil added a commit to likeavirgil/polyglot.js that referenced this issue Jun 29, 2021
likeavirgil added a commit to likeavirgil/polyglot.js that referenced this issue May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants