Update dependencies to fix lifecycle inheritance #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apramana
force-pushed
the
lifecycle
branch
2 times, most recently
from
8ac701f
to
5328964
Compare
sanginovs
approved these changes
Aug 31, 2023
elihart
approved these changes
Sep 1, 2023
|
Please merge asap, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates dependencies to the extent needed to resolve the lifecycle inheritance issue raised in #679 - this includes bumping:
The last two were necessary to fix lint - without them, the project still builds successfully and tests pass.
It also replaces TestLifecycleOwner with the corresponding AndroidX class.