Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate reorder = TRUE #276

Open
maxheld83 opened this issue Sep 3, 2015 · 0 comments
Open

deprecate reorder = TRUE #276

maxheld83 opened this issue Sep 3, 2015 · 0 comments
Labels
Milestone

Comments

@maxheld83
Copy link
Collaborator

from #263 to #273 to #274 to #264 to #275 and what else there might be out there, the re-ordering happening in principal::psych is a bag of hurt for us.

I'd be in favor of just deprecating this option at some point; will substantially simplify the code, and avoid countless potential bugs.

Maybe, for backward compatibility, people can just recognize that the results are actually the same, only presented in a different way.

@maxheld83 maxheld83 added this to the Backlog milestone Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant