Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Support for docker contexts (configured in ~/.docker/) #811

Open
pyhedgehog opened this issue Jan 28, 2023 · 3 comments · May be fixed by #854
Open

FR: Support for docker contexts (configured in ~/.docker/) #811

pyhedgehog opened this issue Jan 28, 2023 · 3 comments · May be fixed by #854
Labels
sprint:pyconus2024 Issues marked for the sprint in PyCon US 2024

Comments

@pyhedgehog
Copy link

It would be good to take advantage of docker context.
Related issue in "sync" library: docker/docker-py#2616

@achimnol
Copy link
Member

achimnol commented May 6, 2024

I'm going to handle this in #748.

@achimnol achimnol added the sprint:pyconus2024 Issues marked for the sprint in PyCon US 2024 label May 20, 2024
@jrfk
Copy link
Collaborator

jrfk commented May 20, 2024

I’ve been thinking about the scope of this issue.
I believe the next steps might be as follows. What do you think?
Apologies if I am off the mark.

  • add docker socket path
    • Add DOCKER_CONTEXT
    • Read files such as ~/.docker/context/meta.json and set the socket
      • Add support for Docker client contexts (e.g., OrbStack)
  • Enable aiodocker to use the functionality of docker context

@achimnol
Copy link
Member

@jrfk Yes, those are the goals.
Please refer my own prior implementation in the Backend.AI project:
https://github.com/lablup/backend.ai/blob/7c255bc5ca27cd582ab2b7f9d6e026df588d77a2/src/ai/backend/common/docker.py#L114

@jrfk jrfk linked a pull request May 20, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sprint:pyconus2024 Issues marked for the sprint in PyCon US 2024
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants