-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement cache for predictions #1334
base: master
Are you sure you want to change the base?
Conversation
Hello @DRMPN! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Code in this pull request contains PEP8 errors, please write the |
with closing(sqlite3.connect(self.db_path)) as conn: | ||
with conn: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Почему бы не реализовать DataCacheDB
как синглтон, подключаясь к БД один раз при инициализации (реинициализации в новых инстансах питона в многопотоке)?
This is a 🙋 feature or enhancement.
Summary
WIP
Context
Resolves #1291