Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for ALL InputData and Data classes methods #1200 #1251

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add unit tests for ALL InputData and Data classes methods #1200 #1251

wants to merge 5 commits into from

Conversation

andreygetmanov
Copy link
Collaborator

@andreygetmanov andreygetmanov commented Jan 19, 2024 •
edited
Loading

Summary

Solution of #1200 issue.
Add unit tests for:

  • 1. Classification tasks:
    • 1.1 Binary classification
    • 1.2 Multitarget classification
  • 2. Regression task
  • 3. Time series forecasting tasks:
    • 3.1 Unidimensional case
    • 3.2 Multi_ts case
    • 3.3 Multidimensional time series case
  • 4. Multimodal case:
    • 4.1 Classification (bi- and multitarget)
    • 4.2 Regression
    • 4.3 Time series forecasting (unidimensional and multi_ts)

Context

Closes #1200

@andreygetmanov
Add unit tests for ALL InputData and Data classes methods #1200
60db221 
 - added tests for from_numpy, from_dataframe, from_csv methods for regression and classification (bi and multi) tasks
 - simple_classification and simple_regression datasets are moved to separate folders
@pep8speaks
Copy link

pep8speaks commented Jan 19, 2024 •
edited
Loading

Hello @andreygetmanov! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 6:1: F401 'typing.Callable' imported but unused
Line 158:52: F811 redefinition of unused 'data_setup' from line 18

Comment last updated at 2024-02-20 13:01:55 UTC

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 19, 2024 •
edited
Loading

All PEP8 errors has been fixed, thanks ❤️

Comment last updated at

@codecov Codecov
Copy link

codecov bot commented Jan 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e726e9) 80.05% compared to head (936d8f9) 80.06%.
Report is 3 commits behind head on master.

❗ Current head 936d8f9 differs from pull request most recent head b5b7a1a. Consider uploading reports for the commit b5b7a1a to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1251   +/-   ##
=======================================
  Coverage   80.05%   80.06%           
=======================================
  Files         149      149           
  Lines       10278    10278           
=======================================
+ Hits         8228     8229    +1     
+ Misses       2050     2049    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicl-nno nicl-nno requested a review from Lopa10ko January 22, 2024 10:28
Lopa10ko
Lopa10ko reviewed Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@Lopa10ko Lopa10ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не уверен, что прав, но я бы не стал плодить множество функций вида get_*_data_from_*, а написал бы одну функцию считывания данных, где можно менять аргументы. кажется, таким образом не будет 100500 функций, каждая из которых служит обвязкой для InputData.from_*

test/unit/tasks/test_regression.py Outdated Show resolved Hide resolved
@andreygetmanov
- refactoring of test_regression.py
936d8f9
@andreygetmanov
- added classification tests for text and image files
e4b92fe 
- refactoring of test_regression.py
- refactoring of test_classification.py
@andreygetmanov
Copy link
Collaborator Author

/fix-pep8

@andreygetmanov
Copy link
Collaborator Author

не уверен, что прав, но я бы не стал плодить множество функций вида get_*_data_from_*, а написал бы одну функцию считывания данных, где можно менять аргументы. кажется, таким образом не будет 100500 функций, каждая из которых служит обвязкой для InputData.from_*

Поправил

Lopa10ko
Lopa10ko reviewed Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@Lopa10ko Lopa10ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lopa10ko Lopa10ko Lopa10ko left review comments

@kasyanovse kasyanovse Awaiting requested review from kasyanovse

@nicl-nno nicl-nno Awaiting requested review from nicl-nno

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit tests for ALL InputData and Data classes methods
3 participants
@andreygetmanov @pep8speaks @Lopa10ko