Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decomoposing the modules #34

Closed
nicl-nno opened this issue Feb 13, 2023 · 0 comments · Fixed by #50
Closed

Decomoposing the modules #34

nicl-nno opened this issue Feb 13, 2023 · 0 comments · Fixed by #50
Labels
refactoring

Comments

@nicl-nno
Copy link

nicl-nno commented Feb 13, 2023 •
edited
Loading

Сейчас основные модули (например, networks.py) очень велики. В них куча классов, сотни строк кода - это тяжело и читается, и поддерживается.

Предложил бы переструктурировать их, создав иерархию папок-модулей и разложив в них файлы по принципу "1 класс - 1 файл" (от него можно отступать, но если это обосновано).
@Roman223 Roman223 linked a pull request Mar 29, 2023 that will close this issue
Decomoposing and code improvement #50
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decomoposing and code improvement aimclub/BAMT
1 participant
@nicl-nno