Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fsync at right places to increase robustness #29

Closed
giovannipizzi opened this issue Jun 19, 2020 · 2 comments · Fixed by #35
Closed

Implement fsync at right places to increase robustness #29

giovannipizzi opened this issue Jun 19, 2020 · 2 comments · Fixed by #35

Comments

@giovannipizzi
Copy link
Member

giovannipizzi commented Jun 19, 2020

See comments and discussion in #15; see also e.g. https://blog.gocept.com/2013/07/15/reliable-file-updates-with-python/, or various Stack Overflow pages like this.

@giovannipizzi
Copy link
Member Author

This might affect performance - moving to 'minimal working version'

@giovannipizzi
Copy link
Member Author

Started to add the logic in 5082148. It's just for loose objects, we need to do it also for packs later. Also, I'm running CI tests to see if this works on Windows (probably it won't, and/or it's not needed there?)
Moving this to later milestone since this is enough to test the most important part of performance, and the rest is for increased robustness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant