-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial structure pk to summary #1051
Add initial structure pk to summary #1051
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1051 +/- ##
==========================================
+ Coverage 67.61% 67.83% +0.21%
==========================================
Files 112 112
Lines 6581 6581
==========================================
+ Hits 4450 4464 +14
+ Misses 2131 2117 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6a822bf
to
c4dcfc4
Compare
@AndresOrtegaGuerrero please review this one next 🙏 |
I have a feeling it was introduce by #1047 , this is only occuring with the external plugins/ |
Indeed. In if not process_node and process_node.exit_status:
return it's evaluating |
@AndresOrtegaGuerrero please retry 🙏 |
I just tested it is fine now ! thank you Edan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #1049