Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial structure pk to summary #1051

Merged
merged 5 commits into from
Jan 5, 2025

Conversation

edan-bainglass
Copy link
Member

@edan-bainglass edan-bainglass commented Jan 3, 2025

Closes #1049

image

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.83%. Comparing base (f792d36) to head (f1e7bf2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
+ Coverage   67.61%   67.83%   +0.21%     
==========================================
  Files         112      112              
  Lines        6581     6581              
==========================================
+ Hits         4450     4464      +14     
+ Misses       2131     2117      -14     
Flag Coverage Δ
python-3.11 67.83% <100.00%> (+0.21%) ⬆️
python-3.9 67.85% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edan-bainglass
Copy link
Member Author

@AndresOrtegaGuerrero please review this one next 🙏

@AndresOrtegaGuerrero
Copy link
Member

I did the test of the pk, it shows the pk , but now i am experiencing a failure

image

which is weird since my dft calculation didnt failed,

image

@AndresOrtegaGuerrero
Copy link
Member

AndresOrtegaGuerrero commented Jan 5, 2025

I have a feeling it was introduce by #1047 , this is only occuring with the external plugins/

@edan-bainglass
Copy link
Member Author

I have a feeling it was introduce by #1047 , this is only occuring with the external plugins/

Indeed. In

if not process_node and process_node.exit_status:
    return

it's evaluating (not A) and B instead of the intended not (A and B). Should've added parentheses. Will fix in this PR.

@edan-bainglass
Copy link
Member Author

@AndresOrtegaGuerrero please retry 🙏

@AndresOrtegaGuerrero
Copy link
Member

I just tested it is fine now ! thank you Edan

Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edan-bainglass edan-bainglass merged commit 4ea95f1 into aiidalab:main Jan 5, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Summary missing information (Input Structure PK)
2 participants