Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relabel/reorganize tabs in "Edit Structure" #1024

Open
9 of 12 tasks
AndresOrtegaGuerrero opened this issue Dec 23, 2024 · 0 comments
Open
9 of 12 tasks

Relabel/reorganize tabs in "Edit Structure" #1024

AndresOrtegaGuerrero opened this issue Dec 23, 2024 · 0 comments
Assignees

Comments

@AndresOrtegaGuerrero
Copy link
Member

AndresOrtegaGuerrero commented Dec 23, 2024

  • Rename title from "Edit Structure" to "Edit structure"

  • Split the "Edit StructureData" tab in two:

    • Tab "Set atom tags". Inside:
    • Change the title also to "Set atom tags"
  • Add a subtitle, in normal font "Integer tags are used to distinguish atoms with the same chemical element. Example: to assign different initial magnetization for antiferromagnetic systems."

  • Make sure the label "Index of atoms" is fully shown (now "Index of at...")

  • Make sure the textbox has some default gray text (that disappears as soon as you type) with an example of the syntax, e.g. "Example: 1,4,5"

  • Add a text on the right of the table that appears saying "Note: the table is scrollable"

  • Now 2..10 starts from index 1 (index in text box is 1-based, and in the table is zero-based?) Keep consistent (1-based) also in table.

  • Add, in the subtitle above, another sentence below the one above: "Note: atom indices are 1-based (first atom has index 1, second atom has index 2, ...)"

  • (not for this tab, but for consistency, on the panel on the right of the 3D viewer, under "Selection", add a sentence below "or expressions: ...): "Note: atom indices are 1-based" aiidalab-widget-base

    • Tab "Set periodicity". Inside:
  • Change title to "Set structure periodicity"

  • Apply the renaming of issue changing the labels of periodicity widget #933

  • Do we need a "Select" button? Maybe just apply selection when the radio button is clicked. We keep it only if there is some "destructive" operation done when this is set. If needs to be kept, rename from "Select" to "Set".

@AndresOrtegaGuerrero AndresOrtegaGuerrero self-assigned this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant