Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML and CSS best practices #6

Open
ahzia opened this issue Aug 31, 2021 · 0 comments
Open

HTML and CSS best practices #6

ahzia opened this issue Aug 31, 2021 · 0 comments

Comments

@ahzia
Copy link
Owner

ahzia commented Aug 31, 2021 •
edited
Loading

In Index.html:

TodoList/src/index.html

Lines 15 to 18 in b479018

<div class="header">
<h3>Todo list</h3>
<i class="fas fa-sync-alt"></i>
</div>

  • Use the Semantic HTML tag <header> instead of div.

  • Avoid lines of code that are too long:

TodoList/src/index.html

Line 9 in b479018

<link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.1.1/css/all.css" integrity="sha384-O8whS3fhG2OnA5Kas0Y9l3cfpmYjapjI0E4theH4iuMD+pLhbf6JI0jIMfYcK3yZ" crossorigin="anonymous" />

TodoList/src/index.html

Line 38 in b479018

<script defer src="https://use.fontawesome.com/releases/v5.1.1/js/all.js" integrity="sha384-BtvRZcyfv4r0x/phJt9Y9HhnN5ur1Z+kZbKVgzVBAlQZX4jvAuImlIz+bG7TS00a" crossorigin="anonymous"></script>

  • Using two spaces instead of a tab for indentation and avoiding blank lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahzia