Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timespan should belong to the solver object #70

Open
ahellander opened this issue Mar 31, 2014 · 4 comments
Open

timespan should belong to the solver object #70

ahellander opened this issue Mar 31, 2014 · 4 comments
Labels
enhancement
Milestone
1.1.0

Comments

@ahellander
Copy link
Owner

Right?
@briandrawert
Copy link
Collaborator

I know why you are suggesting this, the division between 'model' parameters, and 'simulation' parameters. I suggest we keep it in the model object and add it to the solver object. That way the model specification suggests a time span for simulation and the solver can override it.

@ahellander
Copy link
Owner Author

Ok, I like that. Sounds like a plan.

@briandrawert briandrawert added this to the 1.0 milestone Mar 31, 2014
@briandrawert briandrawert added bug and removed question labels Mar 31, 2014
@briandrawert
Copy link
Collaborator

I feel like this issue is tied to #69. We can push this to 1.1.

@briandrawert briandrawert removed this from the 1.0 milestone Apr 1, 2014
@ahellander ahellander added enhancement and removed bug labels Apr 2, 2014
@ahellander
Copy link
Owner Author

Agreed. I have changed the label to enhancement.

@ahellander ahellander added this to the 1.1.0 milestone Dec 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@briandrawert @ahellander