Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency graph for models with custom propensities #66

Open
ahellander opened this issue Mar 28, 2014 · 3 comments
Open

Dependency graph for models with custom propensities #66

ahellander opened this issue Mar 28, 2014 · 3 comments

Comments

@ahellander
Copy link
Owner

There are two ways that immediately comes to mind for how to do this:

1.) Use regular expressions and try to analyze the string propensity function to determine what species it contains.

2.) Explicitly evaluate the propensities to test if they change value when a species changes copy number. (For each propensity, test changing all species in turn)

@briandrawert
Copy link
Collaborator

A third way:
By default make the dependency for a custom propensity dense ones (most inefficient, but always correct). Allow a parameter to the Reaction object that specifies the dependancies: e.g.
A M-M propensity [http://en.wikipedia.org/wiki/Michaelis%E2%80%93Menten_kinetics] would then be:
Reaction(reactants={S:1}, products={P:1}, dependancies=[S,E], propensity_function="k1_E_S/(Km+S)/vol")

@briandrawert
Copy link
Collaborator

Note, there is a related "bug" in that pyurdme always adds the 'vol' (divides if order 2, multiply if order 0) to custom propensities. See pyurdme.py line 1970.

I have made this a separate issue: #68

@ahellander
Copy link
Owner Author

Yeah, that is an option too. However, I think we push this for 1.1 since it becomes "only" a performance issue for custom propensities. Let's add this to the list of enhancements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants