Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation: Implement Ignore / Error handling with PolicyAdviseryFramework #307

Open
oliveregger opened this issue Nov 5, 2024 · 3 comments
Assignees

Comments

@oliveregger
Copy link
Member

org.hl7.fhir.core introduced the PolicyAdviseryFramework to handle/ignore specific errors, warning.

we should try to use that framework too with matchbox's approach of error handling,.

@qligier
Copy link
Member

qligier commented Nov 7, 2024

Are we talking about this one? hapifhir/org.hl7.fhir.core@5696582#diff-24fa08ddadb1ef4846e56ae49f2035ef35a24c438bd75df93c6cb230e90eb63eR852

That allows to suppress messages per FHIRPath (Bundle.entry[2].resource/*Patient/1Pat-DM*/.address[0].country.extension[0].value.ofType(Coding)), or validation message id (e.g. Terminology_TX_Binding_NoSource), but not by message itself.

@qligier qligier self-assigned this Nov 7, 2024
@oliveregger
Copy link
Member Author

yes but could we extend that framework that it would also work by message itself?

@qligier
Copy link
Member

qligier commented Nov 8, 2024

Not without modifying the BaseValidator to change the method suppressMsg calls. Also, we would need to construct the message before that check, instead of after.
So it would not be a better solution than now, in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants