Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventEmitter leak #9

Open
jkp opened this issue Feb 6, 2017 · 1 comment
Open

EventEmitter leak #9

jkp opened this issue Feb 6, 2017 · 1 comment

Comments

@jkp
Copy link

jkp commented Feb 6, 2017

There seems to be an EventEmitter leak in the client code. If an error is thrown when logging in for example, things don't get cleaned up correctly.

I could be wrong but I don't see any calls to removeListener that balance the on calls that are made so this is probably the problem.
@jkp
Copy link
Author

jkp commented Feb 6, 2017

There is also a problem where the socket can be left open in the event of a bad login. Steps to reproduce: call connect() with bad credentials, then you will be left in a state where the runloop fails to exit (the only way to fix it is to close the socket on the client manually - client._socket.close())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkp