Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add filters for beam list views #260

Draft
wants to merge 7 commits into
base: mobile_v15
Choose a base branch
from
Draft

feat: add filters for beam list views #260

wants to merge 7 commits into from

Conversation

Alchez
Copy link
Collaborator

@Alchez Alchez commented Feb 20, 2025

Closes #210.

@Alchez Alchez requested a review from agritheory February 20, 2025 12:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py10100% 
beam
   barcodes.py331457%18, 27, 29, 31, 34, 45–46, 48–49, 54–56, 60–61
   handling_unit.py813754%25, 31, 63–65, 83, 94–95, 101–102, 104–105, 107–108, 110–111, 113, 115–118, 120–122, 124, 126, 128–129, 134, 136, 140, 142–143, 146, 148–149, 157
   printing.py61610%4–6, 8, 11–12, 15–16, 18–21, 24–25, 34–45, 47–54, 58–59, 61–62, 71–75, 78–79, 85–87, 90–91, 94–95, 97–99, 101–102, 104, 109, 111–112
beam/demand
   demand.py3389472%51, 66, 123, 209, 243, 290, 293, 425–426, 428–429, 432–433, 435, 439–444, 446, 448–449, 452, 457, 459–464, 466, 468, 471, 474, 479, 483–485, 490–491, 493, 495–497, 499, 505, 507–510, 512–515, 517, 519, 522–523, 525–526, 529, 543, 560–561, 563–565, 621, 625, 662, 667, 674, 695–696, 707, 713–729, 853
   receiving.py1251786%79, 131, 173, 214, 244, 249–260
   sqlite.py59198%40
   utils.py59788%56, 67, 72–75, 83
beam/doctype/beam_mobile_route
   beam_mobile_route.py30100% 
beam/doctype/beam_settings
   beam_settings.py281739%33–35, 38–39, 41, 48, 53–56, 64–66, 70–72
beam/doctype/handling_unit
   __init__.py9366%12–14
   handling_unit.py150100% 
beam/doctype/warehouse_types
   warehouse_types.py30100% 
beam/overrides
   sales_order.py10640%11–16
   stock_entry.py671774%61–62, 67–74, 80–81, 97, 112, 129, 132–133
   work_order.py10280%14, 16
beam/report/demand_map
   demand_map.py35350%4–5, 7–8, 11–12, 15–16, 103–111, 127, 129–143, 146–147
beam/report/handling_unit_traceability
   handling_unit_traceability.py44440%4–6, 9–11, 30–32, 34–35, 37–38, 41–42, 45–46, 48–49, 51–52, 54–55, 57, 63–65, 67–69, 71, 74–77, 79–81, 83–86, 89–90
beam/scan
   __init__.py1322283%21, 25, 30, 38, 70, 117–118, 128, 130–131, 135, 139–140, 143, 154–155, 159, 180, 209, 211, 229, 232
   config.py26260%4, 6, 9–17, 19–21, 23–26, 28–30, 32–35, 37
   user_login.py31310%1–4, 7–9, 13–15, 17–18, 20–21, 23–25, 27–29, 31–34, 36–41, 43
www/beam
   __init__.py14140%4–7, 10–19
   index.py770%4, 6, 9–13
TOTAL119145561% 

@Alchez Alchez linked an issue Feb 21, 2025 that may be closed by this pull request
[mobile] Filtering on various listviews #210
Open
24 tasks
@Alchez Alchez force-pushed the mobile_v15_filters branch from 794796c to c3e4130 Compare February 21, 2025 10:54
@agritheory
Copy link
Owner

image

An excellent start. I think we can reduce the white space and switch to a two column layout. Another default filter that we had no included in the spec issue is "assigned" / "assigned to me".

@Alchez Alchez mentioned this pull request Feb 24, 2025
Merged
@Alchez
Copy link
Collaborator Author

Alchez commented Feb 24, 2025

@agritheory A few updates:

  • I've added a user filter for the Manufacture, Demand, Receive and Ship views.
    • It was straightforward for the Manufacture list view since that would use Frappe's resource API and the assignment data structure is documented. But I wasn't sure how assignments are stored in the demand DB.
    • I see an assigned string field inside the demand tables, but I'm not sure if that's supposed to represent a single user or a list of users (comma-separated?)
  • I've also added a PR for making the filters a two-column layout over at [beam] use two-column layout for beam filters stonecrop#243.
  • I've added some design questions for scanning filters in the connected issue

@agritheory
Copy link
Owner

z-index issue:

image

@agritheory
Copy link
Owner

@Alchez 1) I think we need to z-index the container, this dropdown shouldn't be pushing the list down.
2) I think the break logic needs to be sync'd with the Stonecrop PR, where it's at 479px.

@crabinak FYI

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agritheory agritheory Awaiting requested review from agritheory

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mobile] Filtering on various listviews
2 participants
@Alchez @agritheory