Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__rand_vec and __rand_vec_base have reserved names #3

Open
AnthonyVH opened this issue Jun 12, 2018 · 1 comment
Open

__rand_vec and __rand_vec_base have reserved names #3

AnthonyVH opened this issue Jun 12, 2018 · 1 comment

Comments

@AnthonyVH
Copy link

According to the C++ standard, it is not allowed to have identifiers containing double underscores anywhere in the name (paragraph 17.4.3.1.2), since all such identifiers are reserved. See also e.g. https://stackoverflow.com/questions/228783 or https://en.cppreference.com/w/cpp/language/identifiers (section "In declarations").

Most likely not an issue, but I figured I might as well mention it.

@hoangmle
Copy link
Member

We should definitely follow the standard here and fix this as it is (still) easy to fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants