Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support settings reloading #42

Open
agoose77 opened this issue Sep 16, 2021 · 0 comments
Open

Feat: support settings reloading #42

agoose77 opened this issue Sep 16, 2021 · 0 comments

Comments

@agoose77
Copy link
Owner

Currently we cache the md instance on the renderer. This means that when the settings are modified, the existing IRenderer instances never reflect the new changes.

Either we make getMarkdownIt return the same object where the settings are unmodified, or we listen to the settings changed signal. I can't think that we necessarily need a unique MarkdownIt instance per-renderer, so perhaps the former option is best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant