PriceSet Max Participants is not being used

[shaneonabike]

Thanks for making an awesome extension to allow for registering participation in other Events via a PriceSet.

I originally setup a Priceset and set the Max Participants within the actual Price Option thinking that this would regulate how many people could attend. It actually seems like this is more regulated by the actual subEvent, which is totally fine. I wanted to propose that this field be removed because it's really confusing otherwise.

To Reproduce

1. Create a Priceset and set one option to Signup as a Participant of a subEvent
2. Set the Max Participants to 2

3. After two registrations people can still register
4. Setting a limit on the subEvent of 5 causes the price option to be blocked (as expected) after 5 registrations

I looked through the code and don't actually see this value being used anywhere.

Proposal

Remove this option completely and just document that for people to set the Max Participants it should be controlled via the subEvent.