Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend app functionality to Deezer #10

Open
Cwpute opened this issue Dec 24, 2021 · 19 comments
Open

Extend app functionality to Deezer #10

Cwpute opened this issue Dec 24, 2021 · 19 comments

Comments

@Cwpute
Copy link

Cwpute commented Dec 24, 2021

Yes, this is coming from someone with almost no knowledge on how this might work.
But!
I do know that ads in Deezer are also signaled by a separate notification which could be detected by the app and subsequently silenced.

I use Deezer and i believe it's among the topmost used streaming apps! many other users might find this helpful 👀

(also happy holidays 🎄)

@aghontpi
Copy link
Owner

Thanks for the suggestion, will add it for sure.

Happy Holidays!

@aghontpi
Copy link
Owner

block deezer ads

@aghontpi
Copy link
Owner

aghontpi commented Dec 26, 2021

deezer is not available in my country and is region locked, (even after using vpn, the app wont let me signin). I have to find a way to overcome this.

is it supported in your country? or are you using a method(vpn,etc...) to make it work?

@Cwpute
Copy link
Author

Cwpute commented Dec 27, 2021

Yes it is supported in my country (France). I didn't know it would be blocked in others !

@aghontpi
Copy link
Owner

added support for Deezer in #11 , closing this issue.

@Cwpute thanks for request !

@Cwpute
Copy link
Author

Cwpute commented Dec 30, 2021

Fantastic ! thank you !!

@aghontpi
Copy link
Owner

😄 yw.

I have to test it for a few days before publishing it, so If you want to test it immediately head over here.

You can also provide feedback on whether it works or not, (im limited to an emulator 😭 , it would be of great help)

@Cwpute
Copy link
Author

Cwpute commented Dec 31, 2021

Tested it just now and it doesn't work :/ the app is running in the notifications and Deezer is checked on in the settings. Not sure why it doesn't work.

@aghontpi
Copy link
Owner

I just tested it now, works as expected 🤔

@aghontpi aghontpi reopened this Dec 31, 2021
@aghontpi
Copy link
Owner

can you take a screenshot of the Deezer notification when an ad plays next time and post it here.

@Cwpute
Copy link
Author

Cwpute commented Dec 31, 2021

Screenshot_20211231-203630

@aghontpi
Copy link
Owner

aghontpi commented Jan 1, 2022

thanks for the screenshot, from the notifications..

  • either ad-silence/app did not recognise the notification or it was killed by system (but if the system has killed it, there would be no notification in the first place)

I can tell the above has happened for sure, because if a configured app (i.e) "Deezer/Spotify.. in preference" posts a new notification, the title of ad-silence would be "Ad-silence . now" but it shows "Ad-silence . 16h", which indicates adsilence last detected something 16 hours ago and did not detect Deezer or anything since. (can you test it again with the build 10 from #11)

or the app might be killed (but notification is not removed...which has a less probability, need logcat to confirm this)

Can you specify the device model/specs? (optional, if you are into dev.. and have a pc, can you take a logcat?. I can send you the instructions)

edit/update: do mention if it works for other apps (spotify/accuradio/Tidal)

@aghontpi
Copy link
Owner

aghontpi commented Jan 1, 2022

If I have extra time available, I can decomple/reverse engineer the Deezer app to patch the location restriction..then I can test it on my device, fingers crossed~

@Cwpute
Copy link
Author

Cwpute commented Jan 2, 2022

My phone is a Huawei Y5 2018 DRA-L21 running on Android 8.10.
I don't think the app was killed as it was listed in the opened-apps window as Deezer was playing.
I'll try to use it with Spotify !
Last time i tried to use Logcat it didn't work… but if someone helps me through i might be able to use it.

@Cwpute
Copy link
Author

Cwpute commented Jan 3, 2022

It works perfectly with Spotify on the same device… so the issue must be specific to the Deezer app.

@aghontpi
Copy link
Owner

aghontpi commented Jan 3, 2022

there should be no hiccups for android 8 andad-silence would not show up in recents 🤔 (its configured not to be seen in recents screen/running apps screen). but Spotify works.. so it clears the possibility of system killing the app.

What problems did you face ? I can help you set it up.

@aghontpi
Copy link
Owner

aghontpi commented Jan 3, 2022

Can you verify Deezer's package name is deezer.android.app, it will be under app Info.

@aghontpi
Copy link
Owner

An update~

I have decided it would be better to merge the Deezer branch #11 into master instead of keeping it stale, So others can test this and report.

Put Deezer under an experimental section and ship with main build. (something like below or a better UI)

experimental-example-ui

@famewolf
Copy link

I have not seen deezer in the list. If it's hidden unless the app is installed I can install it and try to get a logcat along with some screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants