Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distrobox should be created if containter does not exist not if folder does not exists #5

Open
kapi117 opened this issue Oct 23, 2024 · 1 comment

Comments

@kapi117
Copy link
Member

kapi117 commented Oct 23, 2024

currently script is checking if folder exists. better option would be to check if container itself exists - current solution leads to issues if container creation fails

@rayferric
Copy link
Member

rayferric commented Oct 29, 2024

The reason we look at whether the folder exists instead of querying Docker is that when I originally developed the ./distrobox script, I observed that the queries were noticeably slower which negatively impacted user experience.

However, now that I look into it, distrobox ls command is not that slow and could be used. Even better, we could directly run docker/podman container ls -a, which appears to answer instantaneously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants