We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I really like your framework, but I stumbled upon the rather redundant code of App::set(). I'd suggest to use something like this instead:
App::set()
public function set($key, $value) { $keys = explode('/',$key); if (count($keys)>5) return false; $registry =& $this->registry; foreach ($keys as $key) { $registry =& $registry[$key]; } $registry = $value; return $this; }
That way you also won't have to limit the number of keys (but I kept the limit in case you had good reasons for it ^^).
The text was updated successfully, but these errors were encountered:
No branches or pull requests
I really like your framework, but I stumbled upon the rather redundant code of
App::set()
. I'd suggest to use something like this instead:That way you also won't have to limit the number of keys (but I kept the limit in case you had good reasons for it ^^).
The text was updated successfully, but these errors were encountered: