Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we drop "__mailsubject" argument in Forms submissions? #1410

Open
Raruto opened this issue Jan 26, 2021 · 0 comments
Open

Should we drop "__mailsubject" argument in Forms submissions? #1410

Raruto opened this issue Jan 26, 2021 · 0 comments

Comments

@Raruto
Copy link
Contributor

Raruto commented Jan 26, 2021

Honestly, I can't say how much this feature is still in use nowdays..

Overall it might be safer to just listen for this event in order to alter the $options['subject'] property?

$this->app->trigger('forms.submit.before', [$form, &$data, $frm, &$options]);


Related files:

$options['subject'] = $this->param('__mailsubject');

<input type="hidden" name="__mailsubject" value="{{ $options["mailsubject"] }}">


Related issues:


Related pull requests:


Have a nice day,
Raruto

@Raruto Raruto changed the title Should we drop "__mailsubject" argument in submission Forms? Should we drop "__mailsubject" argument in Forms submissions? Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant