Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-W closes Agama installer? #1509

Open
badshah400 opened this issue Jul 28, 2024 · 4 comments
Open

Ctrl-W closes Agama installer? #1509

badshah400 opened this issue Jul 28, 2024 · 4 comments
Labels
agama-live enhancement New feature or request

Comments

@badshah400
Copy link

Started installation, configured everything, and let installation proceed. Once it started I pressed the Ctrl-W button by mistake on the VM window instead of my intended Firefox window and it ended up closing the installer tab inside Firefox. It currently shows a "Welcome to Firefox" tab instead, with no indication as to whether the installation is proceeding or not. Further pressing a Ctrl-W closed off firefox entirely leaving me with a blank only-wallpaper-showing screen.

I know the "Doctor, it hurts when I do so and so" story, but being able to quit the installer midway by simply pressing Ctrl-W should be made impossible, me thinks.

@badshah400
Copy link
Author

Update: it seems to have borked the installation, with no progress for ~20 minutes.

@imobachgs
Copy link
Contributor

Hi @badshah400,

We need to adjust the Firefox configuration a bit to avoid that kind of situations (if possible). I will keep this issue open although we do not plan to work on this soon.

About your "update", please open a separate bug and, if possible, attach the logs so we can figure out what happened.

Thanks!

@imobachgs imobachgs added agama-live enhancement New feature or request labels Jul 29, 2024
@badshah400
Copy link
Author

badshah400 commented Jul 29, 2024

In the least, the web page should warn the user when Ctrl-W is pressed, for example, with a beforeunload event. This is typically done on pages with unsaved filled forms if a user tries to close the window/tab. That should be ok IMO, for the lack of a proper mechanism to prevent browser window/tab closing.

@imobachgs
Copy link
Contributor

We want to have a closer look at Firefox's configuration. beforeunload can work (only when using Agama locally, because I am not sure we want the behavior when connecting remotely). But apart from ctrl+w, there are other keys that we would like to avoid, not to mention that there is a second tab open (that you already found :-) ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agama-live enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants