Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] simplify review router queries #125

Open
davidlhw opened this issue May 18, 2024 · 0 comments
Open

[refactor] simplify review router queries #125

davidlhw opened this issue May 18, 2024 · 0 comments
Labels
enhancement New user-facing feature or request. This Label is used as a category on release notes. good first issue Good for newcomers refactoring

Comments

@davidlhw
Copy link
Contributor

  • There seems to be repetitive code in review.ts under reviews.map...... Maybe we can have a common utility function for this (to avoid code duplication)
  • Imo the reviewFor field under reviews.map.... can be cleaned up by using the reviewLabelType for it so we do not have to use as "professor" | "course") throughout
@davidlhw davidlhw added enhancement New user-facing feature or request. This Label is used as a category on release notes. good first issue Good for newcomers refactoring labels May 18, 2024
@davidlhw davidlhw mentioned this issue May 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New user-facing feature or request. This Label is used as a category on release notes. good first issue Good for newcomers refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidlhw