-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
action is not compatible with docker/build-push-action #9
Comments
👋 Hi there @somdoron I'd personally avoid making blatant breaking changes, but to be honest I'm not sure how much people is currently using the action... I don't think that adding a fallback to the current vars is too hard to do, and we can even display a deprecation notice for it. What do you think? But yep, please feel free to submit a PR addressing this 🙂 |
I agree it would be a nice feature to have so it's possible to switch the "builder backend" by editing a simple line. The drawback is backward compatibility but since this action is young, it might actually be a good time to do it now before it's too late. |
I will give it a try with backward compatibility |
@somdoron did you end up giving a try to make this change? |
I think making them compatible will increase the usage of this action.
@aexvir if you would like I can make a pull request to make them (more) compatible. However, it will probably break the current options.
The text was updated successfully, but these errors were encountered: