Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamically use latest major version on init #437

Open
marc0olo opened this issue Aug 30, 2022 · 4 comments
Open

dynamically use latest major version on init #437

marc0olo opened this issue Aug 30, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@marc0olo
Copy link
Contributor

in the past we had latest tag for both, compiler & node. this recently lead us to a problem with SDK incompatibility to latest compiler version v7.0.1

I think it makes sense to fetch latest (major) release on project initialization. if e.g. aeproject would define 6 for node and 6 for the compiler it should replace the tags accordingly in docker-compose.yml (which we recently introduced here: #432)

aeproject would then use the version defined in docker-compose.yaml by default to start the environment. only if options nodeVersion or compilerVersion is provided a custom version should be used.

this way we would ensure that a user doesn't run into unforeseen problems.

@thepiwo what do you think?

@marc0olo marc0olo added the enhancement New feature or request label Aug 30, 2022
@thepiwo
Copy link
Collaborator

thepiwo commented Aug 30, 2022

I would like it as discussed in the other issue, but there is no such tag yet as far as I know

@marc0olo
Copy link
Contributor Author

I think we won't get the tag as we discussed 😅

also I see one small issue with the other approach. in case of new releases docker wouldn't automatically download the new node version if not explicitly forced by the user.

@thepiwo
Copy link
Collaborator

thepiwo commented Aug 31, 2022

yes it would, as we use pull in the env command

@marc0olo
Copy link
Contributor Author

yes it would, as we use pull in the env command

ok, that's good to know. anyway, I doubt we will see tags like 6 or 7 on dockerhub based on recent discussion.

using the proposed approach here we would definitely avoid unexpected results based on implicit infrastructure changes. we'd always select the version when the project is initialized and then leave it up to the devs to update node/compiler. I actually like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants