Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reference to slots, while still making it possible to refer to them. #7

Open
aeschylus opened this issue Apr 14, 2015 · 2 comments

Comments

@aeschylus
Copy link
Owner

No description provided.

@aeschylus
Copy link
Owner Author

Any ideas about this @mekarpeles?

@mekarpeles
Copy link
Collaborator

on refactor/node-structure I have removed slots. As discussed, we can
change the foreach on Enter and Exit to invoke callbacks set during
initialization of layoutserver. Another option is expecting the parent to
implement an interface like addWindow or rmWindow and having layoutServer
call this function if it exists on parent. You brought up good reasons why
we may want to avoid this.

Bikeshedding, but in terms of following the code, would love for
layoutserver to be renamed to something more intuitive; perhaps
WindowManager (since tiling window managers generally specify this type of
role). When I as a new user see layoutsever, it's not intuitive to me what
it does, other than "serve layouts", which isn't exactly correct -- it
organizes / manages your layout as you make modifications and dispatches to
d3 for rendering. WindowManager This would be my vote.

best wishes + happy hacking,

  • mek

On Mon, Apr 13, 2015 at 9:52 PM, aeschylus [email protected] wrote:

Any ideas about this @mekarpeles https://github.com/mekarpeles?


Reply to this email directly or view it on GitHub
#7 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants