Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snake_case or camelCase for CEL selectors? #259

Open
toumorokoshi opened this issue Jan 9, 2025 · 1 comment
Open

snake_case or camelCase for CEL selectors? #259

toumorokoshi opened this issue Jan 9, 2025 · 1 comment

Comments

@toumorokoshi
Copy link
Member

aep.d recommends using CEL as the filter language. However, the naming of the fields themselves are either snake_case in the case of protobuf, or camelCase in the case of JSON. This means that the filter syntax will be different, depending on whether you are using protobuf or JSON.

This might become problematic, especially if one is trying to pass the filter query directly from a JSON-based frontend to a proto-based backend. We probably need to decide on one, and provide some example or instructions on how the translation would work.

CC @hudlow

@hudlow
Copy link

hudlow commented Jan 9, 2025

I just think the decision to transform field names is a huge mistake. It has so many sharp edges, and almost no benefit at all. snake_case JSON already exists all over the place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants