You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the python script used by this action uses the sourceroot input to resolve relative URIs in the sarif file as well as relative sourceMappingURLs read from the end of a JS file (the output of sourcemap.discover(...)). The first usage makes sense, as the sarif output from github/codeql-action/analyze@v2 uses URLs relative to the root of the repo by default, but I think the second usage is incorrect. My understanding is that the sourceMappingURL value must be a URI, and if it is relative, it should be resolved relative to the JS file it is included in.
When they are instead resolved relative to sourceroot, I'm unable to configure and run this action in a way that both the compiled JS file and its sourcemap can be located successfully.
The text was updated successfully, but these errors were encountered:
evanweible-wf
added a commit
to evanweible-wf/remap-sarif
that referenced
this issue
Nov 6, 2023
Thanks for raising the issue. I'm happy to go ahead and merge. It'd be best to see a sample repo that demonstrates this issue and for me to see that this change resolves it, but I won't make that a blocker for merging
Currently, the python script used by this action uses the
sourceroot
input to resolve relative URIs in the sarif file as well as relativesourceMappingURL
s read from the end of a JS file (the output ofsourcemap.discover(...)
). The first usage makes sense, as the sarif output fromgithub/codeql-action/analyze@v2
uses URLs relative to the root of the repo by default, but I think the second usage is incorrect. My understanding is that thesourceMappingURL
value must be a URI, and if it is relative, it should be resolved relative to the JS file it is included in.When they are instead resolved relative to
sourceroot
, I'm unable to configure and run this action in a way that both the compiled JS file and its sourcemap can be located successfully.The text was updated successfully, but these errors were encountered: