Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abi-decoder's GPL-3.0 license is not compatible with eth95's MIT license #75

Open
lukaw3d opened this issue Apr 19, 2024 · 3 comments
Open

Comments

@lukaw3d
Copy link

lukaw3d commented Apr 19, 2024

"license": "MIT",

"abi-decoder": "^2.4.0",

https://www.npmjs.com/package/abi-decoder

GPL-3.0

@adrianmcli
Copy link
Owner

Hmmm, that sucks. What do you suggest we do?

Should we remove the abi-decoder dependency? I think Wagmi/Viem has a good option now right? They are MIT licensed.

@lukaw3d
Copy link
Author

lukaw3d commented Apr 19, 2024

Simplest is probably remove dependency and do something like

const contractInterface = new ethers.utils.Interface(selectedContract.abi)
receipt.logs.forEach((log) => {
  const evt = contractInterface.parseLog(log)
  const values = evt.args.map(arg => arg.toString())
})

@adrianmcli
Copy link
Owner

Simplest is probably remove dependency and do something like

const contractInterface = new ethers.utils.Interface(selectedContract.abi)
receipt.logs.forEach((log) => {
  const evt = contractInterface.parseLog(log)
  const values = evt.args.map(arg => arg.toString())
})

happy to take a PR for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants