Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of union! and push! #39

Closed
gdalle opened this issue May 3, 2024 · 1 comment · Fixed by #42
Closed

Get rid of union! and push! #39

gdalle opened this issue May 3, 2024 · 1 comment · Fixed by #42

Comments

@gdalle
Copy link
Collaborator

gdalle commented May 3, 2024

Conceptually, tracers are like numbers, so they should not be modified in place.
In particular, when implementing a new pseudo-set type like SortedVector in #38, one should only need to define union
@gdalle gdalle mentioned this issue May 3, 2024
Merged
@adrhill
Copy link
Owner

adrhill commented May 3, 2024 •
edited
Loading

Feel free to address this in #38 by modifying distributive_merge, the mechanism of which is described in #35 here.

@gdalle gdalle mentioned this issue May 3, 2024
Closed
@gdalle gdalle linked a pull request May 3, 2024 that will close this issue
Get rid of union! #42
Merged
@adrhill adrhill mentioned this issue May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get rid of union! adrhill/SparseConnectivityTracer.jl
2 participants
@adrhill @gdalle