Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user select set-type used in tracers #23

Closed
adrhill opened this issue Apr 25, 2024 · 1 comment · Fixed by #31
Closed

Let user select set-type used in tracers #23

adrhill opened this issue Apr 25, 2024 · 1 comment · Fixed by #31
Labels
enhancement New feature or request

Comments

@adrhill
Copy link
Owner

adrhill commented Apr 25, 2024

While internal use of BitSet for the index sets showed a large performance increase on the Brusselator example in #4, it struggles with very large input dimensionalities, as BitSet is designed for use with dense integer sets.

For very large, very sparse index sets, Set{UInt64} or implementations from other packages like SmallCollections.jl might be better suited.

Ideally, users could select the right set type for their task.

CC: @gdalle, @niklasschmitz

@adrhill adrhill added the enhancement New feature or request label May 1, 2024
@gdalle
Copy link
Collaborator

gdalle commented May 1, 2024

To me this is top priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants