Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overwriting methods when generating 2-to-1 overloads on arbitrary types #202

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

adrhill
Copy link
Owner

@adrhill adrhill commented Oct 1, 2024

Fixes an oversight in #197 by separating overloads on arbitrary types from methods defined on tracers only, thus avoiding duplicate overwriting of existing methods.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.74%. Comparing base (9ce962f) to head (ce26ffd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/overloads/utils.jl 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   91.05%   90.74%   -0.32%     
==========================================
  Files          47       47              
  Lines        2080     2107      +27     
==========================================
+ Hits         1894     1912      +18     
- Misses        186      195       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrhill adrhill merged commit f70f532 into main Oct 1, 2024
9 checks passed
@adrhill adrhill deleted the ah/fix-overwritten-methods branch October 1, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants