Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SparseArrays dependency? #181

Closed
adrhill opened this issue Aug 23, 2024 · 1 comment
Closed

Remove SparseArrays dependency? #181

adrhill opened this issue Aug 23, 2024 · 1 comment
Labels
breaking change Requires a breaking release. discussion Discuss design decisions / future direction of the package

Comments

@adrhill
Copy link
Owner

adrhill commented Aug 23, 2024 •
edited
Loading

SparseArrays.jl is a strong dependency of SCT and is used to return Jacobians and Hessians as sparse matrices.
This can be an issue for load times, see JuliaDiff/DifferentiationInterface.jl#416.

By defaulting to a built-in array type (maybe BitMatrix?), we could remove this dependency.

Related issues: #14
@adrhill adrhill added discussion Discuss design decisions / future direction of the package breaking change Requires a breaking release. labels Aug 23, 2024
@adrhill
Copy link
Owner Author

adrhill commented Sep 3, 2024

Won't do. Using DI for sparse AD will always load SparseArrays (at the very least through a package extension), so nothing would be gained from this.

@adrhill adrhill closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Requires a breaking release. discussion Discuss design decisions / future direction of the package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adrhill