Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store patterns in BitMatrices instead of sets #137

Open
gdalle opened this issue Jun 25, 2024 · 5 comments
Open

Store patterns in BitMatrices instead of sets #137

gdalle opened this issue Jun 25, 2024 · 5 comments
Labels
patterns Features regarding sparsity pattern representation

Comments

@gdalle
Copy link
Collaborator

gdalle commented Jun 25, 2024

I want to try this but it might require larger code changes than I thought.
A first hurdle is myempty: for a set it doesn't require further information, but for a sparse array we need to give the ambient size.

@adrhill
Copy link
Owner

adrhill commented Jun 25, 2024

I just read your comment in #135 (comment).
Let me retry to add pattern types first, then we go back to this and #135.

@adrhill
Copy link
Owner

adrhill commented Jun 26, 2024

As mentioned in #135 (comment), depending on the problem, it might actually be reasonable to use "dense" BitVectors and BitMatrices if we just allocate them once.

@adrhill adrhill added the patterns Features regarding sparsity pattern representation label Jun 26, 2024
@adrhill
Copy link
Owner

adrhill commented Aug 15, 2024

Do you still want this or can I close the issue @gdalle?

I can't imagine it being faster than DictHessianPattern since SparseVector and SparseMatrixCSC are based on Vectors of indices and values.

@gdalle
Copy link
Collaborator Author

gdalle commented Aug 15, 2024

I think for small and medium problems using a BitMatrix to store the sparsity pattern in shared (Walther) hessian mode would crush the competition

@gdalle
Copy link
Collaborator Author

gdalle commented Aug 15, 2024

So yeah I'd like to keep this issue open at the least

@adrhill adrhill changed the title Store patterns in sparse vectors/matrices instead of sets Store patterns in sparse BitMatrices instead of sets Aug 15, 2024
@adrhill adrhill changed the title Store patterns in sparse BitMatrices instead of sets Store patterns in BitMatrices instead of sets Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patterns Features regarding sparsity pattern representation
Projects
None yet
Development

No branches or pull requests

2 participants