Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a place to store the kubermatic cluster id #38

Open
3 tasks
nce opened this issue Nov 18, 2022 · 1 comment
Open
3 tasks

Find a place to store the kubermatic cluster id #38

nce opened this issue Nov 18, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@nce
Copy link
Contributor

nce commented Nov 18, 2022

We get the kubeconfig from there:
https://github.com/adorsys/ops-k8s-bootstrap/blob/18d81d1c391083587b9c85dd251a949840a94a05/.github/workflows/pr.yml#L41

The projectID (first cryptic string) is static, but the second id (reflecting clusterID) needs to be configured somewhere.

I've no idea where. These values could/should(?) be masked: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#example-masking-a-string

AC:

  • should be easily found/changed
  • configured in only one place
  • evaluated if this is a "private" information and better stored in Secretsmanager
@nce
Copy link
Contributor Author

nce commented Dec 16, 2022

We used to have the clusterID outputted by terraform. This is not possible if the cluster is newly created and not present in the tfstate.

I've now moved to a static file which we just cat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants