Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Proof class into JwtProof, CwtProof, and LdpVpProof as they are mutually exclusive #3

Open
1 task
Tracked by #4
francis-pouatcha opened this issue Sep 10, 2024 · 2 comments

Comments

@francis-pouatcha
Copy link
Member

francis-pouatcha commented Sep 10, 2024

Prozy of

@nitch2019
Copy link

use a planning slot for more discussion and explanation on this topic

@Awambeng
Copy link
Collaborator

Awambeng commented Oct 22, 2024

I would like to raise a point regarding the proof type used when sending requests to obtain credentials. According to the latest draft of the OpenID for Verifiable Credential Issuance (draft 14), the field name for passing JWT proof for credential request should be 'jwt':

{
  "credential_identifier": "CivilEngineeringDegree-2023",
  "proofs": {
    "jwt": [
      "eyJ0eXAiOiJvcGVuaWQ0dmNpL...Lb9zioZoipdP-jvh1WlA",
      "eyJraWQiOiJkaWQ6ZXhhbXBsZ...KPxgihac0aW9EkL1nOzM"
    ]
  }
}

However, in Keycloak version 25.0.5, the implementation has changed the field name for passing the JWT proof from jwt to proofObject, which is not normative. This discrepancy could lead to confusion and compatibility issues when integrating with systems that adhere to the specification.

I suggest we consider aligning the Keycloak implementation with the specification by retaining the JWT field name for proof types in credential requests. This adjustment could enhance compatibility with other services and reduce inconsistencies between the implementation and the specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants