Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1015 Added option to store checksum for each imported file #1017

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

StephanSchrader
Copy link

What this PR does / why we need it:
With this option it can be configured, that only not already been imported files were imported. Also already imported and changed files can be imported again or import might be fail and aborted.

Which issue this PR fixes:
fixes #1015

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@StephanSchrader StephanSchrader force-pushed the feat/1015_checksum-for-each-file branch 2 times, most recently from 8774816 to 07f584a Compare May 10, 2024 12:13
@StephanSchrader StephanSchrader force-pushed the feat/1015_checksum-for-each-file branch from 07f584a to 713ef32 Compare May 10, 2024 12:50
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.45%. Comparing base (565b3e0) to head (17c0074).

Current head 17c0074 differs from pull request most recent head 6c1ef2f

Please upload reports for the commit 6c1ef2f to get more accurate results.

Files Patch % Lines
...cloak/config/service/checksum/ChecksumService.java 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1017      +/-   ##
============================================
- Coverage     95.50%   95.45%   -0.05%     
- Complexity     1355     1372      +17     
============================================
  Files            81       81              
  Lines          4378     4423      +45     
  Branches        500      503       +3     
============================================
+ Hits           4181     4222      +41     
- Misses           94       98       +4     
  Partials        103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@francis-pouatcha francis-pouatcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephanSchrader can you please merge main branch changes into your branch?

@StephanSchrader StephanSchrader force-pushed the feat/1015_checksum-for-each-file branch from 17c0074 to 713ef32 Compare June 10, 2024 13:40
Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

…015_checksum-for-each-file

# Conflicts:
#	src/main/java/de/adorsys/keycloak/config/model/RealmImport.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple files are imported even if imported in a previous run
2 participants