Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freemarker download is failing #3252

Closed
sxa opened this issue Feb 15, 2023 · 8 comments · Fixed by #3311
Closed

freemarker download is failing #3252

sxa opened this issue Feb 15, 2023 · 8 comments · Fixed by #3311
Labels
buildbreak High priority issues that cause build breaks in jenkins or build scripts

Comments

@sxa
Copy link
Member

sxa commented Feb 15, 2023

What are you trying to do? Run a build, which invokes https://github.com/adoptium/temurin-build/blame/784af5c903f067fec94195597856b3ef9c70ba5f/sbin/prepareWorkspace.sh#L391 to download https://downloads.apache.org/freemarker/engine/2.3.31/binaries/apache-freemarker-2.3.31-bin.tar.gz

Expected behaviour: File is downloaded as it was in builds from the 13th January

Observed behaviour: 404 Not found in the next build from the 29th

Any other comments: Since this is the first time we have fully disabled the builds during the pipeline and it lasted for two weeks it is not clear when this started occurring.

@sxa sxa added the buildbreak High priority issues that cause build breaks in jenkins or build scripts label Feb 15, 2023
@sxa
Copy link
Member Author

sxa commented Feb 15, 2023

FYI @AdamBrousseau is this affecting you?

@keithc-ca
Copy link
Contributor

Freemarker is only needed for UMA builds; OpenJ9 has been using CMake builds for some time: Maybe it's time to stop fetching freemarker?

@AdamBrousseau
Copy link
Contributor

We've actually hacked out the freemarker download some time ago on our end. I think probably when it started failing last time. Never followed up on proper solution probably due to lack of priority.
ibmruntimes@5546579
ibmruntimes/ci-jenkins-pipelines#28
ibmruntimes#3

@sxa
Copy link
Member Author

sxa commented Feb 15, 2023

@keithc-ca Since I haven't been keeping up with OpenJ9 developments can you clarify something for me: if freemarker is a compile time build dependency why does it make any difference whether it's a CMake or UMA build? Is freemarker always skipped on a CMake build?

@keithc-ca
Copy link
Contributor

Freemarker was only ever a build-time dependency (used in UMA tooling). Builds that don't use UMA don't need freemarker. Of course, we will need to stop using the configure option --with-freemarker-jar as that expects that the named file exists.

@sxa
Copy link
Member Author

sxa commented Feb 17, 2023

Of course, we will need to stop using the configure option --with-freemarker-jar as that expects that the named file exists.

Do you build without that option in the openj9 CI? In which case we should definitely follow that in ours.

@nitind
Copy link

nitind commented Feb 21, 2023

It's not uncommon for Apache to move all but the current release to archive.apache.org, and FreeMarker is now at v2.3.32.

@keithc-ca
Copy link
Contributor

Do you build without that option in the openj9 CI? In which case we should definitely follow that in ours.

No, most builds don't use that option; (e.g. the latest jdk11_x86-64_linux build):

20:00:39  + bash configure --with-boot-jdk=/home/jenkins/bootjdks/jdk11 --enable-cuda --with-cuda=/usr/local/cuda-9.0 --with-openssl=fetched --enable-jitserver

eclipse-openj9/openj9#16759 will eliminate the other (unnecessary) uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buildbreak High priority issues that cause build breaks in jenkins or build scripts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants