-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing error to println to prevent misinterpretation #752
Changing error to println to prevent misinterpretation #752
Conversation
To prevent this message being interpreted bas cause for failure in and of itself, I'm changing this to a println. Signed-off-by: Adam Farley <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks
run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from me but we can wait for hte pipeline test to finish before mergingm
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
@adamfarley Looks like some failures for jdk20u on Windows and the pipeline-build-check |
Looks like the failure on Windows wasn't anywhere near my code, so I'm going to merge this check anyway. My code executes prior to the build, and the failure appears to occur after the build stopped outputting for 40-ish minutes and @steelhead31 aborted it. Also, I believe the pipeline-build-check is the superset of the test builds, including Windows jdk20u. FYI. |
To prevent this message being interpreted as cause for failure in and of itself, I'm changing this to a println. Signed-off-by: Adam Farley <[email protected]>
To prevent this message being interpreted as cause for failure in and of itself, I'm changing this to a println. Signed-off-by: Adam Farley <[email protected]> Co-authored-by: Adam Farley <[email protected]>
To prevent this message being interpreted as cause for failure in and of itself, I'm changing this to a println. Signed-off-by: Adam Farley <[email protected]>
To prevent this message being interpreted as cause for failure in and of itself, I'm changing this to a println.
Tested here.
Note: I'm also hoping this prevents the pipeline job from interpreting an unstable job as a cause for overall failure. Since this doesn't break anything, I advocate putting this change in anyway and running a big pipeline to test it in anger.