Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing error to println to prevent misinterpretation #752

Conversation

adamfarley
Copy link
Contributor

To prevent this message being interpreted as cause for failure in and of itself, I'm changing this to a println.

Tested here.

Note: I'm also hoping this prevents the pipeline job from interpreting an unstable job as a cause for overall failure. Since this doesn't break anything, I advocate putting this change in anyway and running a big pipeline to test it in anger.

To prevent this message being interpreted bas cause for failure
in and of itself, I'm changing this to a println.

Signed-off-by: Adam Farley <[email protected]>
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,20"

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@andrew-m-leonard
Copy link
Contributor

run tests

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me but we can wait for hte pipeline test to finish before mergingm

@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,20"

@karianna
Copy link
Contributor

karianna commented Jul 5, 2023

@adamfarley Looks like some failures for jdk20u on Windows and the pipeline-build-check

@adamfarley
Copy link
Contributor Author

@adamfarley Looks like some failures for jdk20u on Windows and the pipeline-build-check

Looks like the failure on Windows wasn't anywhere near my code, so I'm going to merge this check anyway. My code executes prior to the build, and the failure appears to occur after the build stopped outputting for 40-ish minutes and @steelhead31 aborted it.

Also, I believe the pipeline-build-check is the superset of the test builds, including Windows jdk20u. FYI.

@adamfarley adamfarley merged commit fb61ed5 into adoptium:master Jul 6, 2023
andrew-m-leonard pushed a commit to andrew-m-leonard/ci-jenkins-pipelines that referenced this pull request Jul 7, 2023
To prevent this message being interpreted as cause for failure
in and of itself, I'm changing this to a println.

Signed-off-by: Adam Farley <[email protected]>
andrew-m-leonard added a commit that referenced this pull request Jul 7, 2023
To prevent this message being interpreted as cause for failure
in and of itself, I'm changing this to a println.

Signed-off-by: Adam Farley <[email protected]>
Co-authored-by: Adam Farley <[email protected]>
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
To prevent this message being interpreted as cause for failure
in and of itself, I'm changing this to a println.

Signed-off-by: Adam Farley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants